From 17996955e3daa785b5dc499728f5d1a91c2d8c19 Mon Sep 17 00:00:00 2001
From: William Braecky <williambraeckman@yahoo.fr>
Date: Thu, 22 Jun 2017 15:27:29 +0200
Subject: [PATCH] Fix Optional parameters being resolved (#51)

---
 core/src/main/java/co/aikar/commands/RegisteredCommand.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/co/aikar/commands/RegisteredCommand.java b/core/src/main/java/co/aikar/commands/RegisteredCommand.java
index 7a0419a7..2b4e69de 100644
--- a/core/src/main/java/co/aikar/commands/RegisteredCommand.java
+++ b/core/src/main/java/co/aikar/commands/RegisteredCommand.java
@@ -126,6 +126,10 @@ public class RegisteredCommand <R extends CommandExecutionContext<? extends Comm
                 || parameter.getAnnotation(Default.class) != null;
     }
 
+    private boolean isSenderAwareResolver(ContextResolver<?, R> resolver) {
+        return resolver instanceof IssuerAwareContextResolver || resolver instanceof IssuerOnlyContextResolver;
+    }
+
     void invoke(CommandIssuer sender, List<String> args) {
         if (!scope.canExecute(sender, this)) {
             return;
@@ -193,7 +197,7 @@ public class RegisteredCommand <R extends CommandExecutionContext<? extends Comm
                 if (allowOptional && def != null) {
                     args.add(scope.manager.getCommandReplacements().replace(def.value()));
                 } else if (allowOptional && opt != null) {
-                    passedArgs.put(parameterName, isOptionalResolver ? resolver.getContext(context) : null);
+                    passedArgs.put(parameterName, isSenderAwareResolver(resolver) ? resolver.getContext(context) : null);
                     //noinspection UnnecessaryContinue
                     continue;
                 } else if (!isOptionalResolver) {