diff --git a/bukkit/src/main/java/co/aikar/commands/ACFBukkitUtil.java b/bukkit/src/main/java/co/aikar/commands/ACFBukkitUtil.java index 03fc299a..9b1e119b 100644 --- a/bukkit/src/main/java/co/aikar/commands/ACFBukkitUtil.java +++ b/bukkit/src/main/java/co/aikar/commands/ACFBukkitUtil.java @@ -268,12 +268,6 @@ public class ACFBukkitUtil { return null; } String name = ACFUtil.replace(search, ":confirm", ""); - - if (!isValidName(name)) { - issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); - return null; - } - List matches = Bukkit.getServer().matchPlayer(name); List confirmList = new ArrayList<>(); findMatches(search, requester, matches, confirmList); @@ -288,6 +282,10 @@ public class ACFBukkitUtil { //noinspection Duplicates if (matches.isEmpty()) { + if (!isValidName(name)) { + issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); + return null; + } Player player = ACFUtil.getFirstElement(confirmList); if (player == null) { issuer.sendError(MinecraftMessageKeys.NO_PLAYER_FOUND_SERVER, "{search}", name); diff --git a/bukkit/src/main/java/co/aikar/commands/BukkitCommandContexts.java b/bukkit/src/main/java/co/aikar/commands/BukkitCommandContexts.java index 05a5b157..e984f3c9 100644 --- a/bukkit/src/main/java/co/aikar/commands/BukkitCommandContexts.java +++ b/bukkit/src/main/java/co/aikar/commands/BukkitCommandContexts.java @@ -142,12 +142,12 @@ public class BukkitCommandContexts extends CommandContexts matches = new ArrayList<>(ProxyServer.getInstance().matchPlayer(name)); @@ -128,6 +124,10 @@ public class ACFBungeeUtil { } if (matches.isEmpty()) { + if (!isValidName(name)) { + issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); + return null; + } issuer.sendError(MinecraftMessageKeys.NO_PLAYER_FOUND_SERVER, "{search}", name); return null; diff --git a/sponge/src/main/java/co/aikar/commands/ACFSpongeUtil.java b/sponge/src/main/java/co/aikar/commands/ACFSpongeUtil.java index 9ea8903b..44ce0876 100644 --- a/sponge/src/main/java/co/aikar/commands/ACFSpongeUtil.java +++ b/sponge/src/main/java/co/aikar/commands/ACFSpongeUtil.java @@ -17,10 +17,6 @@ public class ACFSpongeUtil { return null; } String name = ACFUtil.replace(search, ":confirm", ""); - if (!isValidName(name)) { - issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); - return null; - } List matches = matchPlayer(name); List confirmList = new ArrayList<>(); @@ -35,6 +31,10 @@ public class ACFSpongeUtil { } if (matches.isEmpty()) { + if (!isValidName(name)) { + issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); + return null; + } Player player = ACFUtil.getFirstElement(confirmList); if (player == null) { issuer.sendError(MinecraftMessageKeys.NO_PLAYER_FOUND_SERVER, "{search}", name); diff --git a/velocity/src/main/java/co/aikar/commands/ACFVelocityUtil.java b/velocity/src/main/java/co/aikar/commands/ACFVelocityUtil.java index 6dab2e18..aa067b45 100644 --- a/velocity/src/main/java/co/aikar/commands/ACFVelocityUtil.java +++ b/velocity/src/main/java/co/aikar/commands/ACFVelocityUtil.java @@ -22,10 +22,6 @@ public class ACFVelocityUtil { public static Player findPlayerSmart(ProxyServer server, CommandIssuer issuer, String search) { CommandSource requester = issuer.getIssuer(); String name = ACFUtil.replace(search, ":confirm", ""); - if (!isValidName(name)) { - issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); - return null; - } List matches = new ArrayList<>(matchPlayer(server, name)); @@ -36,6 +32,10 @@ public class ACFVelocityUtil { } if (matches.isEmpty()) { + if (!isValidName(name)) { + issuer.sendError(MinecraftMessageKeys.IS_NOT_A_VALID_NAME, "{name}", name); + return null; + } issuer.sendError(MinecraftMessageKeys.NO_PLAYER_FOUND_SERVER, "{search}", name); return null; }