funkemunky/commands
1
0
Fork 0
mirror of https://github.com/aikar/commands.git synced 2026-06-22 14:50:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add unregister method for JDA (#174)

Browse Source 
This PR is to allow users to unregister commands from the `JDACommandManager`

Currently slightly flawed, needs research. When re-registering it spits out a load of messages like so:
```
SEVERE: [ACF] ACF Error: settings registered subcommand boss role for root command settings - but it is already defined in settings
Sep 20, 2018 3:58:31 AM com.algorithmjunkie.freelance.gachapon.acf.JDACommandManager log
SEVERE: [ACF] 2 subcommands of the same prefix may not be spread over 2 different classes. Ignoring this.
```

Not sure if this is just for me, or if it's for all.
This commit is contained in:
simpleauthority
2018-10-23 08:00:11 -07:00
committed by Daniel Ennis
parent 01d1496c18
commit aa6fa281cc
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jda/src/main/java/co/aikar/commands/JDACommandManager.java
+12
View File
@@ -161,6 +161,18 @@ public class JDACommandManager extends CommandManager<
}
}
public void unregisterCommand(BaseCommand command) {
for (Map.Entry<String, RootCommand> entry : command.registeredCommands.entrySet()) {
String jdaCommandName = entry.getKey().toLowerCase();
JDARootCommand jdaCommand = (JDARootCommand) entry.getValue();
jdaCommand.getSubCommands().values().removeAll(command.subCommands.values());
if (jdaCommand.isRegistered && jdaCommand.getSubCommands().isEmpty()) {
jdaCommand.isRegistered = false;
commands.remove(jdaCommandName);
}
}
}
@Override
public boolean hasRegisteredCommands() {
return !this.commands.isEmpty();