funkemunky/commands
1
0
Fork 0
mirror of https://github.com/aikar/commands.git synced 2026-05-31 06:11:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rework subclass unusable constructor logging #428

Browse Source 
Users should only need to know information about unusable constructors
if the subclass subcommand doesn't successfully register.
Theory being that the constructor could exist for other purposes
This commit is contained in:
chickeneer
2025-04-12 10:09:44 -05:00
parent b434783ae1
commit ddb827e5b2
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/co/aikar/commands/BaseCommand.java
+6 -2
View File
@@ -283,14 +283,15 @@ public abstract class BaseCommand {
try {
BaseCommand subScope = null;
Constructor<?>[] declaredConstructors = clazz.getDeclaredConstructors();
List<String> unusableConstructorsInfo = new ArrayList<>();
for (Constructor<?> declaredConstructor : declaredConstructors) {
declaredConstructor.setAccessible(true);
Parameter[] parameters = declaredConstructor.getParameters();
if (parameters.length == 1 && parameters[0].getType().isAssignableFrom(this.getClass())) {
subScope = (BaseCommand) declaredConstructor.newInstance(this);
} else {
manager.log(LogLevel.INFO, "Found unusable constructor: " + declaredConstructor.getName() + "(" + Stream.of(parameters).map(p -> p.getType().getSimpleName() + " " + p.getName()).collect(Collectors.joining("<c2>,</c2> ")) + ")");
// Unusable constructor information is only relevant if a valid subScope is not found
unusableConstructorsInfo.add("Found unusable constructor: " + declaredConstructor.getName() + "(" + Stream.of(parameters).map(p -> p.getType().getSimpleName() + " " + p.getName()).collect(Collectors.joining("<c2>,</c2> ")) + ")");
}
}
if (subScope != null) {
@@ -301,6 +302,9 @@ public abstract class BaseCommand {
this.registeredCommands.putAll(subScope.registeredCommands);
} else {
this.manager.log(LogLevel.ERROR, "Could not find a subcommand ctor for " + clazz.getName());
for (String constructorInfo : unusableConstructorsInfo) {
this.manager.log(LogLevel.INFO, constructorInfo);
}
}
} catch (InstantiationException | IllegalAccessException | InvocationTargetException e) {
this.manager.log(LogLevel.ERROR, "Error registering subclass", e);